[DarkDragoon2002] iP by DarkDragoon2002 · Pull Request #95 · nus-cs2113-AY2425S1/ip

DarkDragoon2002 · 2024-09-03T02:52:33Z

No description provided.

1. Renamed Duke to Franz 2. Created the greeting and exit functions 3. Implemented the lines in between the messages

1. Renamed Franz to Juan 2. Implemented Echo feature

1. Added chatFeature Function to chat 2. Neatened Code

1. Creates Task Class 2. Shifted Functions from Main to Task class 3. Created functions to mark and unmark

1. Cleaned up Code 2. Reduced Nesting 3. Added Comments

hzxnancy

Overall, the code looks neat with the extraction of different functions and the use of constructors. The personalisation is very unique which makes this code fun to read, gran trabajo!

However, do take note of the naming of boolean variables.

hzxnancy · 2024-09-04T02:49:47Z

+        helloMessage();
+        lineMessage();
+
+        boolean continueChatting = true;


Boolean variables/methods should be named to sound like booleans.
The same error is present in other parts of the code.

hzxnancy · 2024-09-04T02:53:29Z

+        // Less efficient to create a new scanner everytime but code is much neater
+        // If return True means continue
+        // Else End


This comment looks like a note to self and should not be here

hzxnancy · 2024-09-04T04:17:35Z

+        boolean continueChatting = true;
+        while (continueChatting) {
+            continueChatting = chatFeature();
+        }


Would it be better to extract these lines of code?

hzxnancy · 2024-09-04T04:20:31Z

+            "               ._-'-_ .\n" +
+            "          . '  /_-_-_\\   ` .\n" +
+            "       .'     |-_-_-_-|      `.\n" +
+            "      (       `.-_-_-.'        )\n" +
+            "      !`.                    .'!\n" +
+            "        ! ` .            . ' !\n" +
+            "          ! ! ! ! ! ! ! !  !\n" +
+            "            / /       \\ \\\n" +
+            "          _-| \\___ ___/ /-_\n" +
+            "         (_ )__\\_)\\(_/__( _)\n" +
+            "             ))))\\X\\ ((((\n" +
+            "               \\/ \\/ \n" +


I like this logo, it is very cute!

Sukkaito

In general, LGTM! 👍

Sukkaito · 2024-09-04T05:47:23Z

+        String greeting =
+            "               ._-'-_ .\n" +
+            "          . '  /_-_-_\\   ` .\n" +
+            "       .'     |-_-_-_-|      `.\n" +
+            "      (       `.-_-_-.'        )\n" +
+            "      !`.                    .'!\n" +
+            "        ! ` .            . ' !\n" +
+            "          ! ! ! ! ! ! ! !  !\n" +
+            "            / /       \\ \\\n" +
+            "          _-| \\___ ___/ /-_\n" +
+            "         (_ )__\\_)\\(_/__( _)\n" +
+            "             ))))\\X\\ ((((\n" +
+            "               \\/ \\/ \n" +


ASCII art rules! 👍

Sukkaito · 2024-09-04T05:50:02Z

+        if (line.equals("bye")) {
+            return false;
+        } else if (line.equals("list")) {
+            Task.printTasksList();
+            return true;
+        }
+
+        // Check for mark and unmark or just add task
+        String[] parts = line.split(" ");
+        if (parts[0].equals("mark")){
+            // Mark
+            int taskIndex = Integer.parseInt(parts[1]) - 1;
+            Task.mark(taskIndex);
+        } else if (parts[0].equals("unmark")){
+            // Unmark
+            int taskIndex = Integer.parseInt(parts[1]) - 1;
+            Task.unmark(taskIndex);
+        } else {
+            // else add task
+            Task newTask = new Task(line);
+        }
+


Should this part be extracted out?

Sukkaito · 2024-09-04T05:50:47Z

+
+    // Keep track of tasks
+    private static Task[] tasks = new Task[100];
+    private static int taskNumber = 0;


Perhaps a better name can be made here, like taskCount?

Sukkaito · 2024-09-04T05:53:06Z

+
+    // Object specific variables
+    public String taskString;
+    public boolean taskDone = false;


Should the boolean name here be more intuitive like in the Java coding standard?

DanLinhHuynh-Niwashi · 2024-09-04T11:05:39Z

+    public static void lineMessage() {
+        String line = "____________________________________________________________\n";
+        System.out.print(line);
+    }


For the messages, should it be static variables instead and what the methods do is just printing it out?

DanLinhHuynh-Niwashi · 2024-09-04T11:08:21Z

+        String line = scanner.nextLine();
+        lineMessage();
+
+        if (line.equals("bye")) {


May the command words also be variables, for later use or easier management?

DanLinhHuynh-Niwashi · 2024-09-04T11:09:09Z

+    public static void helloMessage() {
+        String greeting =
+            "               ._-'-_ .\n" +
+            "          . '  /_-_-_\\   ` .\n" +
+            "       .'     |-_-_-_-|      `.\n" +
+            "      (       `.-_-_-.'        )\n" +
+            "      !`.                    .'!\n" +
+            "        ! ` .            . ' !\n" +
+            "          ! ! ! ! ! ! ! !  !\n" +
+            "            / /       \\ \\\n" +
+            "          _-| \\___ ___/ /-_\n" +
+            "         (_ )__\\_)\\(_/__( _)\n" +
+            "             ))))\\X\\ ((((\n" +
+            "               \\/ \\/ \n" +


Love the logo!

DanLinhHuynh-Niwashi · 2024-09-04T11:13:55Z

+        byeMessage();
+        lineMessage();
+    }
+    public static boolean chatFeature(){


As it's a method, should it be named with a verb?

…ommands

Created branch-A-Packages for tracker Packages commit in level-5 branch

branch-A-Packages

wenxin-c

Overall good job so far!! Just a few suggestions for you to consider.

wenxin-c · 2024-09-19T15:16:28Z

+        // Continue chatting as long as user doesn't exit
+        boolean continueChatting = true;
+        while (continueChatting) {
+            // Chat feature to handle user input
+            continueChatting = chatFeature();
+        }


You can consider extracting this part further to match same level of abstraction in this method.
E.g.

readData(); salary = basic * rise + 1000; tax = (taxable ? salary * 0.07 : 0); displayResult();

versus

readData(); processData(); displayResult();

wenxin-c · 2024-09-19T15:19:11Z

+            Task.printTasksList(); // Print task list from Task class
+        }
+        // Handle "mark" command to mark a task as completed
+        else if (line.startsWith("mark ")) {


Try to avoid magic literals(e.g. numbers, strings), you can consider using named constants instead. It will be useful especially when the particular literals are used multiple times in the code.
E.g.

static final double PI = 3.14236; static final int MAX_SIZE = 10; ... return PI; ... return MAX_SIZE - 1;

Thanks for the feedback just updated this!

wenxin-c · 2024-09-19T15:20:54Z

+    }
+
+    // Handles user input and executes corresponding actions
+    public static boolean chatFeature() {


This method is very long, you can consider extracting the details for each case into separate methods. It will be better to keep each method short.

Thanks for the feedback just updated this! I extracted it into another class to make it easier to read

wenxin-c · 2024-09-19T15:22:08Z

+        }
+        // Handle "unmark" command to unmark a task as completed
+        else if (line.startsWith("unmark ")) {
+            try {


Try to keep else if and closing curly bracket on the same line.
E.g.

if (condition) { statements; } else if (condition) { statements; } else { statements; }

Thanks for the feedback just updated this!

Branch level 6

Implemented Data Writing System

…iples

Updating Branch

Implemented DateTime feature and Updated Exception Handling

Branch level 9

Updated JavaDoc Comments

DarkDragoon2002 added 5 commits August 22, 2024 22:41

Level-0 Increment

90c8452

1. Renamed Duke to Franz 2. Created the greeting and exit functions 3. Implemented the lines in between the messages

Level-1

6027a2d

1. Renamed Franz to Juan 2. Implemented Echo feature

Level-2

0d164dd

1. Added chatFeature Function to chat 2. Neatened Code

Level-3

dded6bf

1. Creates Task Class 2. Shifted Functions from Main to Task class 3. Created functions to mark and unmark

A-CodingStandard

d0d0bda

1. Cleaned up Code 2. Reduced Nesting 3. Added Comments

hzxnancy reviewed Sep 4, 2024

View reviewed changes

Sukkaito reviewed Sep 4, 2024

View reviewed changes

DanLinhHuynh-Niwashi reviewed Sep 4, 2024

View reviewed changes

DarkDragoon2002 and others added 7 commits September 6, 2024 14:38

Added ToDo, Deadline and Event

a43c3b2

Added UI Text Testing

6a7f020

Implemented Deadline and Event Constructor Exceptions

0d50273

Implemented ToDo Constructor Exceptions and Error Catching for chat c…

cb16bf3

…ommands

Implemented Packages

913e641

Added Comments

f0c0fab

Created branch-A-Packages for tracker Packages commit in level-5 branch

Merge pull request #1 from DarkDragoon2002/branch-A-Packages

36dbaff

branch-A-Packages

wenxin-c reviewed Sep 19, 2024

View reviewed changes

DarkDragoon2002 and others added 14 commits September 20, 2024 02:26

Implemented ArrayList

2d8b65a

Implemented delete function & cleaned up code

5b59c6f

Implemented Data Writing System

c4ca544

Merge pull request #2 from DarkDragoon2002/branch-Level-6

f0b78b9

Branch level 6

Merge branch 'master' into branch-Level-7

0941170

Merge pull request #3 from DarkDragoon2002/branch-Level-7

9672976

Implemented Data Writing System

Bugfix and Created JAR file

2d5e67e

Migrated UI to separate Class

c88fc8c

Migrate TaskList Functions from Task

e2f954e

Migrated Parser functions from Juan

1e844eb

Fixed Corrupted Data Handling

44b8d55

Extracted Command Handling from Parser and Followed Good Coding Princ…

43e739f

…iples

Merge pull request #4 from DarkDragoon2002/master

075bdcf

Updating Branch

Implemented DateTime feature and Updated Exception Handling

8eff0ee

DarkDragoon2002 and others added 16 commits October 10, 2024 01:22

Implement find function

01d0c9d

Merge pull request #5 from DarkDragoon2002/branch-Level-8

cdf58d0

Implemented DateTime feature and Updated Exception Handling

Merge branch 'master' into branch-Level-9

8d0bb25

Merge pull request #6 from DarkDragoon2002/branch-Level-9

4e5f9fa

Branch level 9

Improved Code Quality

2935ec3

Merge branch 'master' of https://github.com/DarkDragoon2002/ip

e439f74

Updated UI-Text-Testing Files

936c109

Updated JavaDoc Comments

42cbb2c

Merge pull request #7 from DarkDragoon2002/branch-A-JavaDoc

364eab3

Updated JavaDoc Comments

Resolved Merge Conflicts

e64f9dc

Merge branch 'master' of https://github.com/DarkDragoon2002/ip

16bf1b5

Updated README.md

97be193

Update README.md

45abc71

Update README.md

4175b23

Update README.md

98d3df5

Storage Bug Fix

246fbcb

Conversation

DarkDragoon2002 commented Sep 3, 2024

Uh oh!

hzxnancy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sukkaito left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wenxin-c left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants